Skip to content

Remove reference to the iostack from info fetcher #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 30, 2025
Merged

Remove reference to the iostack from info fetcher #1287

merged 4 commits into from
Oct 30, 2025
+23 −2

Conversation

@VianneyRuhlmann
Copy link
Contributor

What does this PR do?

Fixes stop_worker by dropping reference to the IoStack from the info fetcher.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@VianneyRuhlmann VianneyRuhlmann requested a review from a team as a code owner October 29, 2025 18:22
@datadog-official
Copy link

datadog-official bot commented Oct 29, 2025 •
edited
Loading

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 83d1cf3 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Oct 29, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-10-29 21:40:39

Comparing candidate commit 83d1cf3 in PR branch vianney/fix-info-fetcher-holding-ref-to-runtime with baseline commit 3ad7d4a in branch main.

Found 4 performance improvements and 1 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics.

scenario:benching deserializing traces from msgpack to their internal representation

  • 🟥 execution_time [+2.902ms; +3.674ms] or [+4.783%; +6.056%]

scenario:credit_card/is_card_number/37828224631000521389798

  • 🟩 execution_time [-10.182µs; -10.136µs] or [-18.232%; -18.150%]
  • 🟩 throughput [+3971189.861op/s; +3992599.829op/s] or [+22.178%; +22.297%]

scenario:credit_card/is_card_number_no_luhn/37828224631000521389798

  • 🟩 execution_time [-10.196µs; -10.151µs] or [-18.259%; -18.179%]
  • 🟩 throughput [+3979281.327op/s; +4000436.569op/s] or [+22.220%; +22.338%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 83d1cf3 1761773200 vianney/fix-info-fetcher-holding-ref-to-runtime
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.468µs 2.517µs ± 0.022µs 2.512µs ± 0.015µs 2.532µs 2.557µs 2.569µs 2.571µs 2.34% 0.466 -0.465 0.87% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.514µs; 2.520µs] or [-0.120%; +0.120%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 83d1cf3 1761773200 vianney/fix-info-fetcher-holding-ref-to-runtime
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 63.441ms 63.956ms ± 2.100ms 63.690ms ± 0.089ms 63.780ms 63.947ms 72.893ms 84.859ms 33.24% 8.782 78.477 3.28% 0.149ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [63.665ms; 64.247ms] or [-0.455%; +0.455%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 83d1cf3 1761773200 vianney/fix-info-fetcher-holding-ref-to-runtime
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.249µs 3.235µs ± 1.449µs 3.012µs ± 0.033µs 3.042µs 3.717µs 14.095µs 14.928µs 395.62% 7.319 54.868 44.67% 0.102µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.034µs; 3.435µs] or [-6.207%; +6.207%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 83d1cf3 1761773200 vianney/fix-info-fetcher-holding-ref-to-runtime
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 85.294µs 85.559µs ± 0.146µs 85.538µs ± 0.052µs 85.604µs 85.713µs 85.882µs 87.101µs 1.83% 6.267 61.392 0.17% 0.010µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [85.539µs; 85.579µs] or [-0.024%; +0.024%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 83d1cf3 1761773200 vianney/fix-info-fetcher-holding-ref-to-runtime
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 240.026ns 250.126ns ± 12.623ns 244.705ns ± 3.123ns 251.863ns 283.940ns 288.265ns 290.022ns 18.52% 1.877 2.448 5.03% 0.893ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [248.377ns; 251.876ns] or [-0.699%; +0.699%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 83d1cf3 1761773200 vianney/fix-info-fetcher-holding-ref-to-runtime
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 171.452ns 174.749ns ± 3.071ns 174.136ns ± 1.687ns 175.778ns 180.400ns 184.210ns 189.916ns 9.06% 1.989 5.432 1.75% 0.217ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [174.324ns; 175.175ns] or [-0.244%; +0.244%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 83d1cf3 1761773200 vianney/fix-info-fetcher-holding-ref-to-runtime
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.978µs 5.049µs ± 0.048µs 5.040µs ± 0.033µs 5.073µs 5.141µs 5.148µs 5.158µs 2.34% 0.755 -0.742 0.96% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.043µs; 5.056µs] or [-0.133%; +0.133%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 83d1cf3 1761773200 vianney/fix-info-fetcher-holding-ref-to-runtime
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 122.414µs 123.979µs ± 1.515µs 123.709µs ± 0.393µs 124.140µs 125.256µs 131.528µs 138.074µs 11.61% 5.800 43.594 1.22% 0.107µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [123.769µs; 124.188µs] or [-0.169%; +0.169%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 83d1cf3 1761773200 vianney/fix-info-fetcher-holding-ref-to-runtime
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.757µs 25.929µs ± 9.939µs 18.027µs ± 0.131µs 34.522µs 44.420µs 45.570µs 68.224µs 278.46% 0.952 0.584 38.24% 0.703µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.551µs; 27.307µs] or [-5.313%; +5.313%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 83d1cf3 1761773200 vianney/fix-info-fetcher-holding-ref-to-runtime
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.562µs 34.241µs ± 1.124µs 33.721µs ± 0.059µs 33.885µs 36.654µs 36.734µs 37.649µs 11.65% 1.701 0.993 3.28% 0.080µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.085µs; 34.396µs] or [-0.455%; +0.455%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 83d1cf3 1761773200 vianney/fix-info-fetcher-holding-ref-to-runtime
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.739ms 10.759ms ± 0.014ms 10.756ms ± 0.007ms 10.763ms 10.780ms 10.815ms 10.846ms 0.83% 2.388 9.699 0.13% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.757ms; 10.761ms] or [-0.018%; +0.018%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 83d1cf3 1761773200 vianney/fix-info-fetcher-holding-ref-to-runtime
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 496.136µs 496.941µs ± 0.594µs 496.830µs ± 0.253µs 497.130µs 497.650µs 500.519µs 500.815µs 0.80% 3.854 21.520 0.12% 0.042µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1996744.198op/s 2012312.373op/s ± 2392.530op/s 2012759.779op/s ± 1023.507op/s 2013666.531op/s 2014410.793op/s 2014957.662op/s 2015578.180op/s 0.14% -3.823 21.261 0.12% 169.177op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 370.242µs 370.925µs ± 0.323µs 370.894µs ± 0.196µs 371.138µs 371.408µs 371.535µs 372.991µs 0.57% 1.325 6.942 0.09% 0.023µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2681032.025op/s 2695963.086op/s ± 2348.549op/s 2696190.342op/s ± 1424.803op/s 2697551.520op/s 2699249.044op/s 2700722.711op/s 2700938.365op/s 0.18% -1.307 6.807 0.09% 166.067op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 168.423µs 168.801µs ± 0.133µs 168.779µs ± 0.084µs 168.874µs 169.045µs 169.181µs 169.200µs 0.25% 0.621 0.560 0.08% 0.009µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5910181.731op/s 5924131.301op/s ± 4667.179op/s 5924918.333op/s ± 2940.634op/s 5927266.989op/s 5930634.962op/s 5933300.554op/s 5937428.889op/s 0.21% -0.615 0.554 0.08% 330.019op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 36.231µs 36.444µs ± 0.093µs 36.436µs ± 0.057µs 36.499µs 36.601µs 36.673µs 36.744µs 0.85% 0.349 0.176 0.26% 0.007µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 27215240.535op/s 27439260.710op/s ± 70086.666op/s 27445374.829op/s ± 43094.287op/s 27486736.135op/s 27547607.087op/s 27596507.727op/s 27600816.854op/s 0.57% -0.334 0.162 0.25% 4955.876op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 46.182µs 46.301µs ± 0.060µs 46.292µs ± 0.043µs 46.342µs 46.397µs 46.490µs 46.523µs 0.50% 0.856 1.072 0.13% 0.004µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21494699.823op/s 21597802.157op/s ± 28023.562op/s 21602172.763op/s ± 19942.892op/s 21619224.094op/s 21634170.325op/s 21642751.748op/s 21653432.849op/s 0.24% -0.847 1.044 0.13% 1981.565op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [496.859µs; 497.024µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [2011980.792op/s; 2012643.955op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [370.880µs; 370.970µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2695637.600op/s; 2696288.572op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [168.783µs; 168.820µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5923484.475op/s; 5924778.127op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [36.431µs; 36.457µs] or [-0.035%; +0.035%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [27429547.372op/s; 27448974.048op/s] or [-0.035%; +0.035%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [46.293µs; 46.309µs] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21593918.361op/s; 21601685.954op/s] or [-0.018%; +0.018%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 83d1cf3 1761773200 vianney/fix-info-fetcher-holding-ref-to-runtime
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 162.039µs 162.596µs ± 0.378µs 162.555µs ± 0.171µs 162.731µs 163.037µs 163.268µs 166.590µs 2.48% 6.013 60.475 0.23% 0.027µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [162.544µs; 162.648µs] or [-0.032%; +0.032%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 83d1cf3 1761773200 vianney/fix-info-fetcher-holding-ref-to-runtime
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.565ms 14.622ms ± 0.028ms 14.619ms ± 0.014ms 14.633ms 14.657ms 14.711ms 14.802ms 1.25% 2.123 9.663 0.19% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.618ms; 14.626ms] or [-0.027%; +0.027%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 83d1cf3 1761773200 vianney/fix-info-fetcher-holding-ref-to-runtime
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 6.229ms 6.393ms ± 0.039ms 6.396ms ± 0.018ms 6.415ms 6.440ms 6.494ms 6.526ms 2.04% -0.880 3.817 0.61% 0.003ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [6.388ms; 6.399ms] or [-0.085%; +0.085%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 83d1cf3 1761773200 vianney/fix-info-fetcher-holding-ref-to-runtime
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.890µs 3.912µs ± 0.003µs 3.911µs ± 0.001µs 3.913µs 3.915µs 3.918µs 3.922µs 0.28% -2.005 21.942 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 254952555.593op/s 255643788.701op/s ± 173857.281op/s 255658225.446op/s ± 94479.247op/s 255747421.966op/s 255811706.583op/s 255856955.294op/s 257066617.552op/s 0.55% 2.046 22.277 0.07% 12293.566op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 79.024µs 81.357µs ± 0.980µs 81.377µs ± 0.702µs 82.071µs 82.971µs 83.680µs 83.729µs 2.89% 0.008 -0.442 1.20% 0.069µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11943312.958op/s 12293322.904op/s ± 148142.079op/s 12288471.570op/s ± 106814.010op/s 12395423.066op/s 12546018.450op/s 12609878.536op/s 12654419.932op/s 2.98% 0.048 -0.445 1.20% 10475.227op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 71.544µs 72.525µs ± 0.435µs 72.472µs ± 0.282µs 72.785µs 73.254µs 73.542µs 73.737µs 1.75% 0.395 -0.244 0.60% 0.031µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13561705.909op/s 13788922.950op/s ± 82541.842op/s 13798444.258op/s ± 53630.048op/s 13847684.859op/s 13910211.406op/s 13944560.156op/s 13977430.906op/s 1.30% -0.366 -0.271 0.60% 5836.590op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.891µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.917µs 3.920µs 3.927µs 0.39% -0.418 8.359 0.09% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254655831.350op/s 255632931.947op/s ± 218828.503op/s 255649511.927op/s ± 135069.967op/s 255784230.903op/s 255880654.863op/s 255945074.378op/s 257014393.007op/s 0.53% 0.444 8.474 0.09% 15473.512op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 68.271µs 69.372µs ± 0.397µs 69.392µs ± 0.275µs 69.635µs 69.967µs 70.349µs 70.653µs 1.82% 0.109 0.115 0.57% 0.028µs 1 200
credit_card/is_card_number/378282246310005 throughput 14153770.467op/s 14415601.343op/s ± 82516.170op/s 14410920.337op/s ± 57278.195op/s 14475567.125op/s 14543757.075op/s 14579265.895op/s 14647590.588op/s 1.64% -0.073 0.094 0.57% 5834.774op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 45.357µs 45.687µs ± 0.159µs 45.684µs ± 0.133µs 45.833µs 45.922µs 45.952µs 45.980µs 0.65% -0.105 -1.023 0.35% 0.011µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 21748455.192op/s 21888259.268op/s ± 76219.294op/s 21889547.554op/s ± 64126.904op/s 21948565.216op/s 22015350.620op/s 22033267.502op/s 22047108.056op/s 0.72% 0.115 -1.018 0.35% 5389.518op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.430µs 6.437µs ± 0.004µs 6.437µs ± 0.003µs 6.439µs 6.444µs 6.445µs 6.446µs 0.15% 0.347 -0.578 0.06% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 155123910.464op/s 155360730.724op/s ± 90339.514op/s 155356942.823op/s ± 65643.601op/s 155439147.351op/s 155491912.825op/s 155509152.030op/s 155513198.057op/s 0.10% -0.345 -0.581 0.06% 6387.968op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.896µs 3.913µs ± 0.003µs 3.913µs ± 0.002µs 3.915µs 3.917µs 3.919µs 3.928µs 0.36% -0.371 8.096 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254612307.935op/s 255536622.321op/s ± 186505.319op/s 255532488.346op/s ± 114539.528op/s 255663634.679op/s 255755077.091op/s 255866161.706op/s 256670701.833op/s 0.45% 0.392 8.157 0.07% 13187.918op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 60.346µs 63.736µs ± 0.879µs 63.839µs ± 0.574µs 64.331µs 64.940µs 65.157µs 65.510µs 2.62% -0.809 0.812 1.38% 0.062µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15264865.973op/s 15692731.991op/s ± 218935.476op/s 15664346.953op/s ± 140518.681op/s 15821919.090op/s 16061350.122op/s 16308789.173op/s 16571157.666op/s 5.79% 0.901 1.090 1.39% 15481.076op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 53.828µs 54.285µs ± 0.131µs 54.313µs ± 0.062µs 54.366µs 54.449µs 54.534µs 54.538µs 0.41% -1.043 1.231 0.24% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 18335922.828op/s 18421449.651op/s ± 44416.942op/s 18411898.151op/s ± 21031.790op/s 18438255.819op/s 18523866.815op/s 18549359.609op/s 18577794.515op/s 0.90% 1.059 1.265 0.24% 3140.752op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.895µs 3.912µs ± 0.004µs 3.912µs ± 0.001µs 3.914µs 3.917µs 3.924µs 3.937µs 0.63% 2.697 20.368 0.09% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254024691.279op/s 255599255.245op/s ± 232633.874op/s 255635648.391op/s ± 95720.819op/s 255717885.952op/s 255816506.468op/s 255839051.917op/s 256728527.260op/s 0.43% -2.656 20.176 0.09% 16449.699op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 50.165µs 50.535µs ± 0.170µs 50.588µs ± 0.097µs 50.658µs 50.725µs 50.799µs 51.146µs 1.10% -0.388 -0.068 0.34% 0.012µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 19551901.850op/s 19788664.690op/s ± 66762.829op/s 19767457.227op/s ± 37877.102op/s 19831152.687op/s 19910521.433op/s 19921778.460op/s 19934033.375op/s 0.84% 0.405 -0.097 0.34% 4720.845op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 45.345µs 45.667µs ± 0.158µs 45.689µs ± 0.123µs 45.782µs 45.907µs 45.940µs 45.959µs 0.59% -0.145 -0.989 0.34% 0.011µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 21758577.947op/s 21898133.904op/s ± 75591.437op/s 21887120.524op/s ± 58944.267op/s 21959927.003op/s 22024905.664op/s 22041273.789op/s 22053374.604op/s 0.76% 0.155 -0.987 0.34% 5345.122op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.429µs 6.437µs ± 0.005µs 6.435µs ± 0.003µs 6.440µs 6.446µs 6.451µs 6.451µs 0.25% 0.840 0.039 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 155008680.586op/s 155361200.653op/s ± 121401.163op/s 155393085.078op/s ± 77545.868op/s 155458016.932op/s 155508299.091op/s 155536893.465op/s 155555026.139op/s 0.10% -0.837 0.032 0.08% 8584.359op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.911µs; 3.912µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ throughput [255619693.754op/s; 255667883.648op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [81.221µs; 81.493µs] or [-0.167%; +0.167%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12272791.837op/s; 12313853.972op/s] or [-0.167%; +0.167%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [72.464µs; 72.585µs] or [-0.083%; +0.083%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13777483.445op/s; 13800362.456op/s] or [-0.083%; +0.083%] None None None
credit_card/is_card_number/37828224631 execution_time [3.911µs; 3.912µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/37828224631 throughput [255602604.421op/s; 255663259.473op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/378282246310005 execution_time [69.316µs; 69.427µs] or [-0.079%; +0.079%] None None None
credit_card/is_card_number/378282246310005 throughput [14404165.395op/s; 14427037.290op/s] or [-0.079%; +0.079%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [45.665µs; 45.709µs] or [-0.048%; +0.048%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [21877696.007op/s; 21898822.530op/s] or [-0.048%; +0.048%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.436µs; 6.437µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/x371413321323331 throughput [155348210.536op/s; 155373250.912op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255510774.477op/s; 255562470.164op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [63.614µs; 63.858µs] or [-0.191%; +0.191%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15662389.639op/s; 15723074.342op/s] or [-0.193%; +0.193%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [54.267µs; 54.303µs] or [-0.033%; +0.033%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [18415293.890op/s; 18427605.412op/s] or [-0.033%; +0.033%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.912µs; 3.913µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255567014.427op/s; 255631496.062op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [50.511µs; 50.558µs] or [-0.047%; +0.047%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [19779412.004op/s; 19797917.376op/s] or [-0.047%; +0.047%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [45.645µs; 45.688µs] or [-0.048%; +0.048%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [21887657.658op/s; 21908610.151op/s] or [-0.048%; +0.048%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.436µs; 6.437µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [155344375.620op/s; 155378025.687op/s] or [-0.011%; +0.011%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 83d1cf3 1761773200 vianney/fix-info-fetcher-holding-ref-to-runtime
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 185.469µs 185.952µs ± 0.314µs 185.936µs ± 0.180µs 186.099µs 186.328µs 187.329µs 187.726µs 0.96% 2.223 9.545 0.17% 0.022µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5326916.175op/s 5377733.754op/s ± 9058.324op/s 5378199.348op/s ± 5210.852op/s 5383828.621op/s 5388499.026op/s 5390771.210op/s 5391722.816op/s 0.25% -2.190 9.329 0.17% 640.520op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 17.808µs 17.878µs ± 0.031µs 17.876µs ± 0.021µs 17.902µs 17.928µs 17.945µs 17.968µs 0.52% 0.223 -0.318 0.17% 0.002µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 55652961.229op/s 55933600.869op/s ± 96160.783op/s 55941833.657op/s ± 66244.979op/s 55991884.471op/s 56077377.614op/s 56128052.011op/s 56153980.822op/s 0.38% -0.215 -0.323 0.17% 6799.594op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.534µs 10.579µs ± 0.037µs 10.572µs ± 0.011µs 10.589µs 10.613µs 10.643µs 11.027µs 4.30% 8.695 100.303 0.35% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 90688864.369op/s 94527843.815op/s ± 324947.362op/s 94585414.945op/s ± 99290.606op/s 94666391.517op/s 94787175.683op/s 94828671.320op/s 94926399.679op/s 0.36% -8.415 95.754 0.34% 22977.248op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [185.909µs; 185.996µs] or [-0.023%; +0.023%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5376478.357op/s; 5378989.151op/s] or [-0.023%; +0.023%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [17.874µs; 17.883µs] or [-0.024%; +0.024%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [55920273.910op/s; 55946927.829op/s] or [-0.024%; +0.024%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.574µs; 10.584µs] or [-0.049%; +0.049%] None None None
normalization/normalize_name/normalize_name/good throughput [94482809.236op/s; 94572878.394op/s] or [-0.048%; +0.048%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.09%. Comparing base (c365938) to head (83d1cf3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1287      +/-   ##
==========================================
+ Coverage   71.91%   72.09%   +0.18%     
==========================================
  Files         368      368              
  Lines       58146    58088      -58     
==========================================
+ Hits        41814    41880      +66     
+ Misses      16332    16208     -124
Components Coverage Δ
datadog-crashtracker 50.65% <ø> (-0.03%) ⬇️
datadog-crashtracker-ffi 5.86% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 88.19% <100.00%> (+0.32%) ⬆️
data-pipeline-ffi 88.19% <ø> (ø)
ddcommon 80.95% <ø> (-3.36%) ⬇️
ddcommon-ffi 73.84% <ø> (ø)
ddtelemetry 60.02% <ø> (+0.03%) ⬆️
ddtelemetry-ffi 21.24% <ø> (ø)
dogstatsd-client 83.26% <ø> (ø)
datadog-ipc 82.39% <ø> (ø)
datadog-profiling 76.90% <ø> (ø)
datadog-profiling-ffi 62.12% <ø> (ø)
datadog-sidecar 37.69% <ø> (+0.44%) ⬆️
datdog-sidecar-ffi 15.88% <ø> (+2.17%) ⬆️
spawn-worker 55.18% <ø> (ø)
tinybytes 92.44% <ø> (ø)
datadog-trace-normalization 98.24% <ø> (ø)
datadog-trace-obfuscation 94.17% <ø> (ø)
datadog-trace-protobuf 59.65% <ø> (ø)
datadog-trace-utils 90.15% <ø> (+0.15%) ⬆️
datadog-tracer-flare 64.98% <ø> (+3.94%) ⬆️
datadog-log 75.57% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dd-octo-sts
Copy link

dd-octo-sts bot commented Oct 29, 2025 •
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 71.36 MB 71.36 MB +0% (+8 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.25 MB 7.25 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.20 MB 9.20 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 83.70 MB 83.70 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 18.55 MB 18.55 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 65.77 KB 65.77 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 129.26 MB 129.27 MB +0% (+8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 678.14 MB 678.17 MB +0% (+28.70 KB) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.93 MB 5.93 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 65.77 KB 65.77 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 17.51 MB 17.51 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 32.46 MB 32.46 MB -0% (-8 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 15.81 MB 15.81 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 66.79 KB 66.79 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 131.44 MB 131.45 MB +0% (+8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 666.67 MB 666.70 MB +0% (+27.68 KB) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 4.55 MB 4.55 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 66.79 KB 66.79 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 18.66 MB 18.66 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 30.52 MB 30.52 MB -0% (-8 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 63.96 MB 63.96 MB +0% (+8 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.56 MB 8.56 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 78.42 MB 78.42 MB +0% (+8 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.91 MB 9.91 MB 0% (0 B) 👌

@VianneyRuhlmann
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 30, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-10-30 14:06:14 UTC ℹ️ Start processing command /merge

2025-10-30 14:06:20 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 39m (p90).

2025-10-30 14:40:01 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 44057f4 into main Oct 30, 2025
37 checks passed
@dd-mergequeue dd-mergequeue bot deleted the vianney/fix-info-fetcher-holding-ref-to-runtime branch October 30, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paullegranddc paullegranddc paullegranddc approved these changes

@hoolioh hoolioh hoolioh approved these changes

Assignees

No one assigned

Labels

data-pipeline mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@VianneyRuhlmann @codecov-commenter @paullegranddc @hoolioh